Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.16 #325

Merged
merged 7 commits into from
May 8, 2024
Merged

v0.16 #325

merged 7 commits into from
May 8, 2024

Conversation

npty
Copy link
Member

@npty npty commented Apr 18, 2024

Description

AXL-3805

This PR prepares the upcoming v0.16.0 release includings:

  • Upgraded axelar-cgp-solidity to 6.3.0 to enable support for Node.js version >= 20
  • Fixed an issue with the generation of commandId
  • Changed the type of executeData from 0x${string} to string to ensure compatibility with most libraries and clients
  • Corrected the documentation for the estimateGasFee function regarding gas limit calculation
  • Resolved an issue with the calculation of L1 gas fees when the source and destination tokens have different decimal places

canhtrinh and others added 5 commits April 18, 2024 19:24
* chore: fix decimals issue with l2 dest chains

chore: delete unused test

* 0.16.0-alpha.1

* chore: improve convertTokenAmount impl

* chore: refactor bignumber amount conversion

---------

Co-authored-by: npty <[email protected]>
* chore: fix gas limit function doc (#316)

* chore: fix gas limit function doc

* chore: remove mantle

* chore: fix commandId generation

* chore: update comment

* chore: remove unused var

* chore: update testnet rpc
* chore: fix gas limit function doc (#316)

* chore: fix gas limit function doc

* chore: remove mantle

* chore: change executeData type from `0x${string}` to `string` (#317)

* chore: change executeData type from `0x${string}` to `string`

* chore: fix build error

* chore: fix testnet rpc

* Update issue templates

* chore: bump axelar-cgp-solidity to 6.3.0

---------

Co-authored-by: Canh Trinh <[email protected]>
Copy link
Contributor

@StephenFluin StephenFluin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit

@@ -1,5 +1,5 @@
import { AssetConfig } from "../assets/types";
import { parseUnits } from "ethers/lib/utils";
import { formatUnits, parseUnits } from "ethers/lib/utils";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linter error about not using formatUnits

@jonator
Copy link
Contributor

jonator commented May 6, 2024

Would appreciate a merge here! The node engine requirement in the solidity package is blocking our updates to our @osmosis-labs/web package with our move to node v20

@canhtrinh canhtrinh merged commit de261a9 into main May 8, 2024
4 checks passed
@canhtrinh canhtrinh deleted the v0.16 branch May 8, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants