-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.16 #325
Conversation
* chore: fix decimals issue with l2 dest chains chore: delete unused test * 0.16.0-alpha.1 * chore: improve convertTokenAmount impl * chore: refactor bignumber amount conversion --------- Co-authored-by: npty <[email protected]>
* chore: fix gas limit function doc (#316) * chore: fix gas limit function doc * chore: remove mantle * chore: fix commandId generation * chore: update comment * chore: remove unused var * chore: update testnet rpc
* chore: fix gas limit function doc (#316) * chore: fix gas limit function doc * chore: remove mantle * chore: change executeData type from `0x${string}` to `string` (#317) * chore: change executeData type from `0x${string}` to `string` * chore: fix build error * chore: fix testnet rpc * Update issue templates * chore: bump axelar-cgp-solidity to 6.3.0 --------- Co-authored-by: Canh Trinh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one nit
src/libs/AxelarQueryAPI.ts
Outdated
@@ -1,5 +1,5 @@ | |||
import { AssetConfig } from "../assets/types"; | |||
import { parseUnits } from "ethers/lib/utils"; | |||
import { formatUnits, parseUnits } from "ethers/lib/utils"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linter error about not using formatUnits
Would appreciate a merge here! The node engine requirement in the solidity package is blocking our updates to our @osmosis-labs/web package with our move to node v20 |
Description
AXL-3805
This PR prepares the upcoming v0.16.0 release includings:
6.3.0
to enable support for Node.js version >= 20commandId
executeData
from0x${string}
tostring
to ensure compatibility with most libraries and clientsestimateGasFee
function regarding gas limit calculation